doc: fix warnings and add guidance around the use of Py_FindMethod

encukou / py3c

A Python 2/3 compatibility layer for C extensions

http://py3c.readthedocs.org

MIT License

59 stars 20 forks source link

doc: fix warnings and add guidance around the use of Py_FindMethod #47

Closed davvid closed 3 years ago

davvid commented 3 years ago

Add a "Py_FindMethod and Generic Attributes" section to document the use of Py_FindMethod.

Document how to upgrade old code that uses Py_FindMethod() from a custom tp_getattr function.

Closes #22 Signed-off-by: David Aguilar davvid@gmail.com

davvid commented 3 years ago

I tried building the docs this morning and I hit a number of sphinx warnings. I've added the warning fixes to this PR, but if you'd prefer that they be split out to a separate PR please let me know. Thanks again for py3c!

davvid commented 3 years ago

Good idea, less is more. I just rebased and dropped that last section. Thanks for the review.

encukou commented 3 years ago

Thank you!