search

encyclical / laudato-si

A web-friendly copy of the encyclical, for educational purposes
MIT License
1 stars 0 forks source link

Deep linking broken by Twitter's URL shortener #2

Open englishm opened 9 years ago

englishm commented 9 years ago

The URL detection in Twitter's Mac app (at least) didn't consider the closing ] at the end of a URL to be part of that URL. This broke highlighting in the shortened link. I was able to work around this issue by appending extra, ignored characters:

cc: @donohoe

englishm commented 9 years ago

@donohoe: let me know if you want me to file upstream issues for any of these Emphasis-related nitpicks or if you'd rather not be CC'd here anymore. Thanks again for your work on a great tool!

donohoe commented 9 years ago

This was a bug we picked up on but didn't do anything about at the time since (a) was Twitter specific, and (b) NYT used Bitly for short urls and those were just fine (and those worked fine with Twitter).

Still, its a nuisance.

I think the real solution is using an alternative to brackets ([]).

Worth reporting to Twitter? https://support.twitter.com/forms/feature_report

jasonphillips commented 9 years ago

It sounds like Bitly integration through an explicit Tweet button might be worth adding. Perhaps a very minimal way of presenting a Twitter icon in the corner etc when an anchor or highlighting is selected?

englishm commented 9 years ago

Filed a bug with Twitter, but then realized that brackets might not actually be allowed in HTTP URI fragments as defined by RFC7230 section 2.7 and RFC3986 section 3.5 and 3.3. If I'm reading the BNF correctly, I think it's an issue with Emphasis.

I like the idea of having convenient sharing buttons that take highlighting into account. Separate issue?

jasonphillips commented 9 years ago

Should be fixed if we implement https://github.com/encyclical/laudato-si/issues/3 with URL shortening