end2endzone / RapidAssist

RapidAssist is a lite cross-platform library that assist you with the most c++ repetitive tasks.
MIT License
5 stars 0 forks source link

Replace usage of preprocessor 'WIN32' by '_WIN32' - Windows only #73

Closed end2endzone closed 3 years ago

end2endzone commented 3 years ago

The usage of WIN32 preprocessor is used on multiple platform to detect 32 bit builds. To detect if win32 api is available on a system, _WIN32 preprocessor should be used.

Also preprocessor that starts with an underscore character are compiler specific.

end2endzone commented 3 years ago

This bug was identified when trying to silence warning C4996 about deprecated 'std::tr1' namespace (#74). Implementing the solution specified in #74 (adding -DCMAKE_CXX_FLAGS=/D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING at the end of cmake commands) seems to undefine the WIN32 preprocessor.