endail / hx711-pico-c

Implementation of single and multiple HX711 use via RP2040's state machine
https://endail.github.io/hx711-pico-c/
MIT License
32 stars 7 forks source link

Unused parameter in release build causes compile-time error #45

Closed endail closed 1 year ago

endail commented 1 year ago

https://github.com/endail/hx711-pico-c/blob/7a390087c2548b2d58f76aa7e896b03760bc812b/include/hx711.h#L269-L281

assert is removed in release causing hx pointer to go unused. Perhaps a macro instead?

endail commented 1 year ago

Release code now compiles.

endail commented 1 year ago

hx711__assert_hx_initd function replaced with CHECK_HX711_INITD macro which is only enabled in DEBUG builds.