search

endangeredoxen / fivecentplots

A Python plotting analgesic
https://endangeredoxen.github.io/fivecentplots
11 stars 6 forks source link

overloading of builin `input` #25

Closed ktetz closed 3 years ago

ktetz commented 3 years ago

fcp.version== 0.4.0

This line 15 overloads the builtin "input" and then breaks the set_theme

15> with open(os.path.join(os.path.dirname(file), r'version.txt'), 'r') as input: version = input.readlines()[0]

... 874> entry = input('Entry: ')

fix to use a different variable name such as fid:

with open(os.path.join(os.path.dirname(file), r'version.txt'), 'r') as fid: version = fid.readlines()[0]

endangeredoxen commented 3 years ago

OK I updated this for future patch release 0.4.2 and next release 0.5.0.

BTW pip install should put you on v0.4.1 not 0.4.0 → I recommend upgrading

ktetz commented 3 years ago

Seems I had cloned and was in the master branch which was is set to 0.4.0: https://github.com/endangeredoxen/fivecentplots/blob/master/fivecentplots/version.txt

Will stash these changes if you're making them and check out 0.4.2 and/or 0.5.0 (and hopefully make the next issue / fix a PR!)