search

endaoment / endaoment-contracts

Solidity contracts for Endaoment's on-chain Donor-Advised Fund
Other
14 stars 3 forks source link

Audit Item C01 #76

Closed mds1 closed 4 years ago

mds1 commented 4 years ago

Closes #15

The core functionality is complete and this is ready for review. Before merging, I think we should do the following

  1. Add tests for the new updateEndaomentAdmin functions of FundFactory and OrgFactory
  2. Optionally make things a bit more DRY by (both of these may not be worth the effort since these are simple things that are duplicated):
    1. Pulling IFundFactory and IOrgFactory into a new interface file called IFactory and use that in both places
    2. Pulling out the updateEndaomentAdmin functions into their own contract so we can inherit it

Please review carefully as there are a lot of architecture changes! Thanks to @apbendi for helping with design the new architecture

CantelopePeel commented 4 years ago

Replying to point 1: -Yup! Point 2: -Completely agrees lets do that.

mds1 commented 4 years ago

Last commit completes everything that was left todo in the original description of the PR, so this is ready for final review