search

endclothing / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
150 stars 79 forks source link

Add Summary Collector #2

Open danvirsen opened 5 years ago

danvirsen commented 5 years ago

This is basically buffcode's code slightly tweaked to make it mergeable with this fork.

There are no tests and the only storage adapter that is implemented is Redis, so I wouldn't say it's ready for a merge just yet.

I'll try to get some time to take a look at tests and the other storage adapters, but I'm not sure when that might be. If someone else would like to take a look at it, they're more than welcome. 🙂

martinssipenko commented 4 years ago

@danvirsen can you please update your branch to be up to date with master?

danvirsen commented 4 years ago

Sorry for the delay. I had email notifications turned off and didn't notice the responses. I pulled in master, so it should be up to date. I also added type hints and fixed some formatting issues that phpcs complained about.

martinssipenko commented 4 years ago

@danvirsen tests are missing

danvirsen commented 4 years ago

Yes, I'm aware. I will try to take some time to write tests, but I'm not sure when that will be.

marcospassos commented 4 years ago

Any updates on this?

NoelDavies commented 4 years ago

Hi @marcospassos, I'm afraid I no longer work at EndClothing. So one of the developers there should be maintaining this soon.

marcospassos commented 4 years ago

@NoelDavies Thank you for replying!