search

endclothing / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
150 stars 77 forks source link

Add code style check into CI pipeline #21

Closed martinssipenko closed 4 years ago

martinssipenko commented 4 years ago

Adds checking of coding standard (PSR-12) as part of CI pipeline.

Resolves #18

martinssipenko commented 4 years ago

I’ll rebase this if #20 is merged first. Or if this gets merged as squash, then #20 can be closed.

NoelDavies commented 4 years ago

I Merged in #20 - You can rebase this and I can merge this in

martinssipenko commented 4 years ago

@NoelDavies done

martinssipenko commented 4 years ago

Ugh, the test are failing because #17 was merged without working CI, I'll try to fix it.

NoelDavies commented 4 years ago

Ah sorry mate. I'm just going through them as I can.

martinssipenko commented 4 years ago

@NoelDavies can you take a look at #22 and merge it?

martinssipenko commented 4 years ago

I'm sorry for confusion, tests are failing due to bug in guzzle in version below 6.3. I'm updating minimum guzzle version which fixes the issue.

martinssipenko commented 4 years ago

@NoelDavies it's now green, after merging this master branch builds will also become green.

NoelDavies commented 4 years ago

This would have to be a major version change as the dependency for guzzle changes.

martinssipenko commented 4 years ago

@NoelDavies It's a minor version change for guzzle which is backwards compatible, should also be a minor version for this package. Either way when using guzzle < 6.3 with current master it will not work, you will get the same error that was caught in tests.

martinssipenko commented 4 years ago

@NoelDavies can we merge this to get CI green again?

NoelDavies commented 4 years ago

Apologies I thought I'd merged this