search

endclothing / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
150 stars 77 forks source link

Update phpunit to version 8 #22

Closed martinssipenko closed 4 years ago

martinssipenko commented 4 years ago

I've updated phpunit to version 8 and fixed all the warning it produces. Once we merge this we can fix failing tests in master and #21 .

NoelDavies commented 4 years ago

Tests failed on 73-lowest?

martinssipenko commented 4 years ago

Yes, it's because guzzle in version below 6.3 has a bug. I'm updating minimum guzzle version which fixes the issue.

martinssipenko commented 4 years ago

I'm sorry for confusion, I got things mixed up a bit, closing this PR.