search

endclothing / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
150 stars 79 forks source link

Refactored tests #28

Closed martinssipenko closed 1 year ago

martinssipenko commented 4 years ago

This PR reorganizes tests so that APCu and BlackBox tests are executed during CI flow.

Closes #26

martinssipenko commented 4 years ago

@NoelDavies I'm also keen on moving the contents of src/Prometheus/ directory to src/ as the Prometheus is obsolete when using PSR-4. Do you reckon I should do it in this PR?

martinssipenko commented 4 years ago

@NoelDavies any updates on this?

NoelDavies commented 4 years ago

@NoelDavies I'm also keen on moving the contents of src/Prometheus/ directory to src/ as the Prometheus is obsolete when using PSR-4. Do you reckon I should do it in this PR?

I'd probably create a new PR for this and add it to a major release as people maybe including it directly. or have custom autoloaders, etc.

martinssipenko commented 4 years ago

@NoelDavies I'm also keen on moving the contents of src/Prometheus/ directory to src/ as the Prometheus is obsolete when using PSR-4. Do you reckon I should do it in this PR?

I'd probably create a new PR for this and add it to a major release as people maybe including it directly. or have custom autoloaders, etc.

In that case this PR is ready for review.

martinssipenko commented 4 years ago

Any updates on this? Anything I can do to get it merged?

NoelDavies commented 4 years ago

@martinssipenko One of the guys at End should be able to help you out. But again, I no longer work there - Apologies.