endclothing / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
150 stars 77 forks source link

Change read_timeout to be string #29

Closed fbhdk closed 4 years ago

fbhdk commented 4 years ago

PHP gives error: TypeError: Redis::setOption() expects parameter 2 to be string

This is because the read_timeout is set as an option, which must be a string. This should also be updated in the docs.

NoelDavies commented 4 years ago

@fbhdk Can you add a docs change for this please bud? <3

fbhdk commented 4 years ago

@fbhdk Can you add a docs change for this please bud? <3

Done as well :)