search

endclothing / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
150 stars 77 forks source link

update redis port datatype #36

Closed ghost closed 4 years ago

NoelDavies commented 4 years ago

Can you add a unit test to validate this case please

ghost commented 4 years ago

Can you add a unit test to validate this case please

sorry, can you add that instead of me? I am out of home for days.

NoelDavies commented 4 years ago

Hi @jose116, I think it's better if you add the unit test as you're the author of the proposed change. It should outline where the existing issue is and what it fixes. Also please include a full description in your initial post.