search

endclothing / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
150 stars 79 forks source link

Maintained fork #56

Open LKaemmerling opened 4 years ago

LKaemmerling commented 4 years ago

First of all, thank you @endclothing guys for maintaining this package after Jimdo.

Sadly it looks like this repository is not maintained anymore (last activity was in Feb.), so I forked it to https://github.com/promphp/prometheus_client_php. I just released v1.0.3 with a few minor fixes (most important is the removed Guzzle requirement).

I plan to continue to maintain the project, so I would recommend moving to this version. I use the Prometheus client myself in several projects, so you can expect to have an active maintainer with me! (Just as a side note, i work mostly for Open Source stuff @hetznercloud, so i will have time to maintain it)

Maybe @endclothing, if you don't plan to maintain it again, could you add a note to the readme?

L3tum commented 4 years ago

How did you remove the Guzzle dependency?

In the PushGateway.php in your repo it still clearly uses it?

LKaemmerling commented 4 years ago

Yeah you are right Thank you!

I moved it to require-dev, because if was needed within the tests (but phpstorm didn't find the usage within the PushGateway). I will takle this next week when I am back from vacation. My first idea would be to remove the pushgateway support in the first place and add an additional package which's allows usage of the pushgateway, because not everyone needs the pushgateway support.

L3tum commented 4 years ago

I'd like to ask you to keep the PushGateway support, though doing so in a separate package would also be okay.

I'll see if I can see to do something on this next week, my work is probably okay with me dedicating some time to this as we're using it in a lot of projects.

LKaemmerling commented 4 years ago

Hey @L3tum,

i "moved" the whole push-gateway support into a dedicated package: https://github.com/LKaemmerling/prometheus_push_gateway_php

Could you please test too? I plan to release a version (1.0.0 of the Push Gateway and 2.0.0 of the Prometheus client [because the removing is a breaking change]) within the next few days, when i don't encounter any other problems within my projects.

L3tum commented 4 years ago

@LKaemmerling Ah, cool! I'll test that when I have some time. Looks good though.

In the meantime I also forked your repo 😄 https://github.com/L3tum/prometheus_client_php I've done some pretty extensive changes over the weekend to make it more streamline to what a project at my company would look like. The next step would be to throw out all those test cases and make some good ones that don't require spinning up 5 containers. Maybe I'll do a PR for your repo once I'm done

LKaemmerling commented 4 years ago

Feel free to open a PR :) As i said, i plan to maintain an easy usable fork with as few as needed dependencies :) Maybe your use case might help others too, so feel free to contribute everything and i will try to find a good path between specific "use-cases improvements" and improvements that will help other too :)

LKaemmerling commented 4 years ago

Just for the record (cc @L3tum) i just published v2.0.0 of the fork without the PushGateway support. The Pushgateway client was also released as v1.0.0 

composer require promphp/prometheus_client_php
composer require promphp/prometheus_push_gateway_php
LKaemmerling commented 4 years ago

Hey @L3tum,

would you volunteer to maintain the new fork together with me (under https://github.com/PromPHP)?