search

endclothing / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
150 stars 79 forks source link

Confusion Between Minimum PHP version (7.2 or 7.3) #61

Open rogojagad opened 3 years ago

rogojagad commented 3 years ago

I notice there are differences for the minimum PHP version on the package's readme.md and the composer.json

On the readme.md, it is said that the minimum PHP version is PHP ^7.3

Screenshot from 2021-01-20 11-40-43

But the rule on composer.json state that the minimum PHP version is ^7.2

"require": { "php": "^7.2", "ext-json": "*", "guzzlehttp/guzzle": "^6.3", "symfony/polyfill-apcu": "^1.6" },

I think the mistake on the readme.md since the composer.json is the one that is consumed by the composer. I will gladly open a Pull Request if this issue is confirmed.

Thank you.