endeavouros-team / EndeavourOS-ISO

EndeavourOS ISO framework based on Arch-ISO
GNU General Public License v3.0
333 stars 56 forks source link

Add "ibt=off" to kernel parameters list for Nvidia boot option #39

Closed mrvictory1 closed 1 year ago

mrvictory1 commented 2 years ago

Adds "ibt=off" to kernel parameters list for Nvidia boot option. Without this, Nvidia module fails to load if ISO is booted on Intel Gen11 or newer. More info here: https://forum.garudalinux.org/t/nvidia-gpu-users-watch-out-for-kernel-5-18-update/19923

killajoe commented 2 years ago

question is if it will may cause issue on other hardware ?
Is it valid the same for current kernel? 6.0.2 ? https://bugs.archlinux.org/task/74891 also mentioned only older kernel versions.

dalto8 commented 2 years ago

I think that any missing/invalid kernel options would just be ignored. Disabling IBT shouldn't cause compatibility issues.

I suspect the only issue would be we are disabling a security feature. If we only do it on the ISO, that is a pretty small risk.

My bigger concern would be it will create a situation where someone can successfully install and then it will not boot afterwards. I am not sure if that is better or worse. There are pros and cons.

mrvictory1 commented 2 years ago

My bigger concern would be it will create a situation where someone can successfully install and then it will not boot afterwards.

If this commit gets merged Nvidia&Intel Gen11+ users will be able to boot ISO and install it but booting the installed system will result in Nvidia driver failing to load. I want to modify Calamares so if it detects Nvidia (and Intel Gen11+) it will add ibt=off but to be able to reach the installer in the first place (on desktops this issue may cause display to go blank) ibt=off should be added in the ISO.

killajoe commented 2 years ago

we could add a new boot entry giving it a name that matches where you need it.. And it is possible to detect hardware and add options but this is nothing easy to do. Hardware detection is not so far developed that we simply add one to the already working framework.. And in this case i am not sure if this will be present forever or if one future update will resolve it ?
Could be a temporary fix would be the easier solution.

mrvictory1 commented 2 years ago

The "ibt=off" parameter does nothing if you are running any CPU but Intel Gen11+ and also it does not persist to installed system, I don't see any harm off adding by default on the ISO.

dalto8 commented 2 years ago

I don't see any harm off adding by default on the ISO.

I agree. The only issue is the installed system issue.

I want to modify Calamares so if it detects Nvidia (and Intel Gen11+) it will add ibt=off

I am less comfortable with this. Perhaps it would be better to switch to the open source drivers in this case.

killajoe commented 1 year ago

needs to be recreated anyway.. and also more likely something general to add for both ISO and installed systems. I would recommend discussing this on the forum so others can join the discussion instead of only us here..

mrvictory1 commented 1 year ago

FINALLY this is fixed upstream!! https://www.gamingonlinux.com/2023/02/nvidia-5303002-mainline-beta-driver-rolls-out-plus-a-new-vulkan-beta-driver/