endeavouros-team / calamares

Distribution-independent installer framework
https://calamares.io
17 stars 13 forks source link

fix for theming seperation for all DEs #8

Closed killajoe closed 1 year ago

killajoe commented 1 year ago

adding separation for theming/settings packages to all DEs to make it easy to unselect: 2023-02-16_13-23

dalto8 commented 1 year ago

I like the idea but I think it is confusing like that. It makes the DEs too nested.

What if we put it inside the DE instead of at the same level?

dalto8 commented 1 year ago

I think something like this would be better for a few reasons:

image

killajoe commented 1 year ago

To be true you are right on that we do not want users to not install the settings we add to fix stuff they was complaining about in the first place. And also if we do not change it it is possible to not install the settings/theming by selecting the packages. On the other side I have had exactly the same for xfce4 for long time already. It would look the same as long as you do not start editing packages:

2023-02-16_22-40

2023-02-16_22-40_1

Could be needed to improve the given information and not call it theming may keep the same as for the packages and call it settings.. But i would agree more to not change it at all, which would also keep the format cleaner and easier to handle. i would now more like to remove the subgroup from xfce4 too would be more consequent. ;)

dalto8 commented 1 year ago

Doesn't alternative above provide a "best of both worlds"? Give them the ability to easily uncheck the theming as a group without the nesting situation?

killajoe commented 1 year ago

Doesn't alternative above provide a "best of both worlds"? Give them the ability to easily uncheck the theming as a group without the nesting situation? yes it would not show up like "I HAVE TO CLICK" how this is formatted in yaml? (so i can see how it looks in real live ; )

dalto8 commented 1 year ago
- name: "KDE-Desktop"
  description: "KDE-Plasma Desktop - Simple by default, powerful when needed."
  hidden: false
  selected: false
  critical: true
  subgroups:
      - name: "EndeavourOS Theming"
        description: "EndeavourOS plasma theming (unselect to install vanilla)"
        selected: false
        packages:
            - eos-plasma-sddm-config
            - eos-settings-plasma
  packages:
    - ark
    - audiocd-kio
    - bluedevil
    - breeze-gtk
    - dolphin
    - gwenview
    - kcalc
    - kate
    - kdeconnect
    - kde-gtk-config
    - khotkeys
    - kinfocenter
    - kinit
    - kio-fuse
    - konsole
    - kscreen
    - kwallet-pam
    - okular
    - plasma-desktop
    - plasma-disks
    - plasma-nm
    - plasma-pa
    - powerdevil
    - print-manager
    - sddm-kcm
    - solid
    - spectacle
    - xsettingsd
killajoe commented 1 year ago

oh yes i like yaml exactly for this ;)

killajoe commented 1 year ago

This is a good middleway.. i will go to reformat soon..