endeavouros-team / endeavouros-i3wm-setup

The beloved EndeavourOS default i3 (has gaps) theme and setup dotfile repo
GNU General Public License v3.0
434 stars 119 forks source link

changed the config to increase and decrease brightness #103

Closed Pratyay360 closed 4 months ago

Pratyay360 commented 8 months ago

I have addressed the issue related to adjusting brightness in i3wm by implementing the 'brightnessctl' package in my configuration. This solution has resolved the problem with the laptop's brightness control button.

Pratyay360 commented 7 months ago

removed package brightnessctl from here to be added into the package file, as your requested changes

killajoe commented 6 months ago

still this should be added as an commented option.

Pratyay360 commented 6 months ago

have raised pull request in the package section

killajoe commented 6 months ago

The question about why it should be added and if the current implementation is causing any issue is still open.

killajoe commented 6 months ago

I would have no issue to add the option commented, with the info that it is alternative to the one that is set-up already.. and indeed that you will need to install the package to use the option. I will not change a working implementation and add packages to the list of the install process without any reason.