search

endeavouros-team / endeavouros-i3wm-setup

The beloved EndeavourOS default i3 (has gaps) theme and setup dotfile repo
GNU General Public License v3.0
434 stars 119 forks source link

Play-Pause doesn't work #117

Closed CoutHi closed 3 months ago

CoutHi commented 3 months ago

For me, the play pause function with playerctl wasn't working. I fixed it by changing bindsym XF86AudioPlay exec --no-startup-id playerctl play to bindsym XF86AudioPlay exec --no-startup-id playerctl play-pause And commenting out the same function for pause.

killajoe commented 3 months ago

you want to do a Pull Request for the change?

CoutHi commented 3 months ago

you want to do a Pull Request for the change?

I really wanted to but have no idea how

CoutHi commented 3 months ago

I just did the request, sorry if there are mistakes with it. Not quite versed in the etiquette yet.

killajoe commented 3 months ago

https://github.com/endeavouros-team/endeavouros-i3wm-setup/commit/4d7ed615c78c6af495c15f5eb3c9267f89a0e22c

https://github.com/endeavouros-team/endeavouros-i3wm-setup/releases/tag/2.4

killajoe commented 3 months ago

Thanks for your contribution, everyone needs to start somewhere me was the same some times ago.

CoutHi commented 3 months ago

Glad to have helped. It's a great i3 setup.

killajoe commented 3 months ago

Glad to have helped. It's a great i3 setup.

and contributions like yours makes it stay like that !