search

endeavouros-team / endeavouros-i3wm-setup

The beloved EndeavourOS default i3 (has gaps) theme and setup dotfile repo
GNU General Public License v3.0
451 stars 121 forks source link

Alternative brightness control option using brightnessctl #132

Open Yocracra opened 3 months ago

Yocracra commented 3 months ago

I can only control my ASUS TUF laptop using backlightctl, so I edited volume_brightness.sh and the i3 config to include a backlightctl option. While I was there, I made volume/brightness step size an argument for volume_brightness.sh so it can be set right in the i3 config.

If someone could test that the original method is still functional on their device, that'd be great.

This is my first ever PR so feedback is very much welcome :)

killajoe commented 2 months ago

it needs some more details on the 2 commits about what exactly the changes does and why they should be added, this is a specified generic setup, defaults should be working on common devices without the need to change. Have a look here on the commit messages: https://github.com/EndeavourOS-Community-Editions/sway/commit/8234c3750c2356a0b0894f8fb89403011a9b232a

Yocracra commented 1 month ago

The latest commit has more details in the commit message. Thanks