endeavouros-team / welcome

Source code for the Welcome app
GNU General Public License v3.0
6 stars 1 forks source link

Cyrillic (and possibly some other) languages unreadable in EOS tools when using the gnome desktop environment #6

Closed blind-confused closed 7 months ago

blind-confused commented 7 months ago

as one of the devs already explained to me, it's because kgx (the new gnome terminal) is not supported to be used by EOS tools, that's why it goes with the fallback terminal, which is xterm. But... if your system has a language that is not using Latin alphabet (like anything Cyrillic), this is what it ends up looking like: Снимок экрана от 2024-04-10 02-39-51 this disrupts daily system maintenance tasks, like EOS mirror updating, pacnew file management, etc. a lot of users might not know that they just need to install another terminal, so they might never know how to fix the issue. I'm not sure whether any other languages are turned into squares, perhaps Chinese, Hindi, other non-Latin ones might be unreadable too? so... perhaps using another terminal as the fallback option would be better? Unless support for all languages can be ensured in xterm somehow? or perhaps support for kgx should be added? (as a side note, xterm also never follows dark mode either :D)

dalto8 commented 7 months ago

Last I looked at kgx, it didn't support the terminal closing after a command is run(As virtually every other terminal could do). This made it a poor host for most of our tasks. Has that support been added?

killajoe commented 7 months ago

seems it simply falls back to xterm, what indeed looks very ugly and poorly decided from the outside world ;)

killajoe commented 7 months ago

https://github.com/endeavouros-team/eos-bash-shared/blob/443c81b64dc4b237fc1ae4c346903f062935b96b/eos-script-lib-yad.conf#L14

and:

https://github.com/endeavouros-team/eos-bash-shared/blob/443c81b64dc4b237fc1ae4c346903f062935b96b/eos-script-lib-yad#L347

dalto8 commented 7 months ago

I suppose we could install an additional terminal with gnome if kgx still lacks support.

killajoe commented 7 months ago

Last I looked at kgx, it didn't support the terminal closing after a command is run

let me check.. if it is even the same anymore..

dalto8 commented 7 months ago

I just tested it. It still appears to be the case.

killajoe commented 7 months ago

Bildschirmfoto vom 2024-04-15 15-24-37 same... it does not close.

dalto8 commented 7 months ago

Looks like it is a long standing issue: https://gitlab.gnome.org/GNOME/console/-/issues/135

I guess our options are:

killajoe commented 7 months ago

Would be good to add one that supports all languages and is running on wayland and X11 the same ?

Looks like it is a long standing issue: https://gitlab.gnome.org/GNOME/console/-/issues/135

I do not see any dev responding there anyway..

manuel-192 commented 7 months ago

This is the list of supported terminals (in file eos-script-lib-yad):

        xfce4-terminal
        konsole
        gnome-terminal
        mate-terminal
        lxterminal
        deepin-terminal
        terminator
        qterminal
        alacritty
        tilix
        termite
        xterm
        kitty
        terminology
        sakura

in the order they are tried. These can close the terminal in the end. The only way to prefer another terminal outside this list is by setting a value to variable EOS_YAD_TERMINAL in file /etc/eos-script-lib-yad.conf.

As @dalto8 said, we could consider installing gnome-terminal for gnome systems.

killajoe commented 7 months ago

https://github.com/endeavouros-team/calamares/commit/8ef0c6757d0fca4e8209ba7e6873b0a0d8227b79

killajoe commented 7 months ago

2024-04-20_21-39 2024-04-20_21-38 Tested on Release candidate ;)