search

endel / js2php

JavaScript (ES6) to PHP source-to-source transpiler.
https://endel.github.io/js2php/
MIT License
333 stars 41 forks source link

replace function fix #20

Closed 2pha closed 7 years ago

2pha commented 7 years ago

String replace function would not work if the first argument was a variable, fixed that. While I was there I added a couple of Number static functions (isInteger, isFinite).

endel commented 7 years ago

Hey @2pha, thanks for your pull-request!

I noticed that one test is failing (about RegExp), do you know what could it be?

https://travis-ci.org/endel/js2php/builds/258037589

2pha commented 7 years ago

Oh, sorry. Yes I know what it is. I will fix it.

2pha commented 7 years ago

Thanks for this repository, I sometimes want a class in both JS and PHP, this will come in very handy.

endel commented 7 years ago

Great, thanks! 🎉 @2pha