Feature requests: Augment bounce capabilities

[SlimeDog]

Thanks for the update. Nice to see that you're still around.

Tested VoidSpawn 1.19.3 on Paper 1.16.5-730.

In-game in the world of interest, executed

/vs option set bounce 15

worlds.yml now looks like this

world_skyblock:
  mode: touch
  options:
    message: Where were you going? Count that as a death!
    hybrid: true
    command: op:stats ${player.name} DEATHS ++1;op:bsbadmin deaths add ${player.name}
      1;op:mvtp ${player.name} e:world_void:0.5,64,0.1:0:0
    bounce: '15'

The bounce is very good. Several items of note:

• Bounce is not listed by the info subcommand.
• In the test case (BSkyBlock), the fall was 127 meters. The height of the bounce appears to be approximately 22 meters. It would be nice to be able to specify the height. By default, it should be the height of the fall (plus a meter or two?) if that can be captured. Otherwise, it would be nice to have an option to set the height -- that is, the Y-coordinate at the top of the bounce (assuming that the bottom is Y=0).
• Extra credit: It would be nice to be able to configure repeated bounces as a decreasing percentage of the height. So the first bounce is the full height, the next is slightly shorter, the next shorter still, etc.
• Bounce is reported in-game for each second of bounce. I am not sure what is being reported, and in any event, I would like it to be silent -- at least, as an option.

  Bounce!0.0,2.9860210961020428,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0
  Bounce!0.0,2.0,0.0

[endercrest]

Hey! Thanks for the feedback. Those messages are definitely not meant to be there, will look into getting that patched up. I will also look into integrating some of your suggestions for bounce.

[SlimeDog]

Thanks.

[endercrest]

Have packaged up the fix for debug messages showing up when bounce is enabled. Should become available on Spigot once approved on Bukkit

[SlimeDog]

Thanks. The debug messages are gone in VoidSpawn 1.9.4. Interestingly, according to the source tree, only pom.xml changed, and only the version string. No code changes?

[SlimeDog]

BTW: The other issues remain.

[SlimeDog]

From downloaded 1.9.4 sources, mvn clean succeeds, but produces multiple WARNING messages

[WARNING] 
[WARNING] Some problems were encountered while building the effective model for com.endercrest.voidspawn:VoidSpawn:jar:1.19.4-SNAPSHOT
[WARNING] 'version' contains an expression but should be a constant. @ com.endercrest.voidspawn:VoidSpawn:1.19.4${snapshot}, /Users/richard/Downloads/Minecraft/plugins/workspace/VoidSpawn-master/pom.xml, line 5, column 14
[WARNING] 'dependencies.dependency.systemPath' for pl.islandworld.api:IslandWorld:jar should not point at files within the project directory, ${basedir}/lib/IslandWorld.jar will be unresolvable by dependent projects @ com.endercrest.voidspawn:VoidSpawn:1.19.4${snapshot}, /Users/richard/Downloads/Minecraft/plugins/workspace/VoidSpawn-master/pom.xml, line 27, column 25
[WARNING] 'dependencies.dependency.systemPath' for com.bgsoftware:SuperiorSkyblock2:jar should not point at files within the project directory, ${basedir}/lib/SuperiorSkyblock2-b38.jar will be unresolvable by dependent projects @ com.endercrest.voidspawn:VoidSpawn:1.19.4${snapshot}, /Users/richard/Downloads/Minecraft/plugins/workspace/VoidSpawn-master/pom.xml, line 34, column 25
[WARNING] 'dependencies.dependency.systemPath' for com.wasteofplastic:askyblock:jar should not point at files within the project directory, ${basedir}/lib/askyblock.jar will be unresolvable by dependent projects @ com.endercrest.voidspawn:VoidSpawn:1.19.4${snapshot}, /Users/richard/Downloads/Minecraft/plugins/workspace/VoidSpawn-master/pom.xml, line 59, column 25
[WARNING] 'build.plugins.plugin.version' for org.sonatype.plugins:munge-maven-plugin is missing. @ com.endercrest.voidspawn:VoidSpawn:1.19.4${snapshot}, /Users/richard/Downloads/Minecraft/plugins/workspace/VoidSpawn-master/pom.xml, line 124, column 21
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 

Subsequent mvn compile succeeds, but produces multiple WARNING messages and failures

[WARNING] Could not transfer metadata org.spigotmc:spigot-api:1.15.2-R0.1-SNAPSHOT/maven-metadata.xml from/to bintray-tastybento-maven-repo (http://dl.bintray.com/tastybento/maven-repo): Authorization failed for http://dl.bintray.com/tastybento/maven-repo/org/spigotmc/spigot-api/1.15.2-R0.1-SNAPSHOT/maven-metadata.xml 403 Forbidden
[WARNING] Failure to transfer org.spigotmc:spigot-api:1.15.2-R0.1-SNAPSHOT/maven-metadata.xml from http://dl.bintray.com/tastybento/maven-repo was cached in the local repository, resolution will not be reattempted until the update interval of bintray-tastybento-maven-repo has elapsed or updates are forced. Original error: Could not transfer metadata org.spigotmc:spigot-api:1.15.2-R0.1-SNAPSHOT/maven-metadata.xml from/to bintray-tastybento-maven-repo (http://dl.bintray.com/tastybento/maven-repo): Authorization failed for http://dl.bintray.com/tastybento/maven-repo/org/spigotmc/spigot-api/1.15.2-R0.1-SNAPSHOT/maven-metadata.xml 403 Forbidden
[WARNING] Could not transfer metadata net.md-5:bungeecord-chat:1.15-SNAPSHOT/maven-metadata.xml from/to bintray-tastybento-maven-repo (http://dl.bintray.com/tastybento/maven-repo): Authorization failed for http://dl.bintray.com/tastybento/maven-repo/net/md-5/bungeecord-chat/1.15-SNAPSHOT/maven-metadata.xml 403 Forbidden
[WARNING] Failure to transfer net.md-5:bungeecord-chat:1.15-SNAPSHOT/maven-metadata.xml from http://dl.bintray.com/tastybento/maven-repo was cached in the local repository, resolution will not be reattempted until the update interval of bintray-tastybento-maven-repo has elapsed or updates are forced. Original error: Could not transfer metadata net.md-5:bungeecord-chat:1.15-SNAPSHOT/maven-metadata.xml from/to bintray-tastybento-maven-repo (http://dl.bintray.com/tastybento/maven-repo): Authorization failed for http://dl.bintray.com/tastybento/maven-repo/net/md-5/bungeecord-chat/1.15-SNAPSHOT/maven-metadata.xml 403 Forbidden
[WARNING] Could not transfer metadata net.md-5:bungeecord-parent:1.15-SNAPSHOT/maven-metadata.xml from/to bintray-tastybento-maven-repo (http://dl.bintray.com/tastybento/maven-repo): Authorization failed for http://dl.bintray.com/tastybento/maven-repo/net/md-5/bungeecord-parent/1.15-SNAPSHOT/maven-metadata.xml 403 Forbidden
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!

Similarly, subsequent mvn package succeeds, but produces multiple WARNING messages and failures.

I think it likely that you have some environment variables that resolve most of the above. Please advise.

[SlimeDog]

Control the bounce boundaries and attributes, especially:

The height of the bounce appears to be approximately 22 meters. It would be nice to be able to specify the height. By default, it should be the height of the fall (minus a defined number of meters -- see next item) if that can be captured. Otherwise, it would be nice to have an option to set the height -- that is, the Y-coordinate at the top of the bounce (the bottom would be minY=-59 for overworlds and minY=0 for nether and end worlds). It would be nice to be able to configure the decrease for repeated bounces. So the first bounce would be the full height (Y-Ymin) minus a defined number of meters, decreasing by the same amount with each bounce. Something like

# Decrease in meters for each bounce
decrease-per-bounce: 5

So the number of bounces would depend on the height of the fall. Short fall, just a few bounces; long fall, many more bounces.

[SlimeDog]

See the referenced issue. Development of physics-based bounced is limited by MC terminal velocity.