search

endernewton / tf-faster-rcnn

Tensorflow Faster RCNN for Object Detection
https://arxiv.org/pdf/1702.02138.pdf
MIT License
3.65k stars 1.57k forks source link

Fix the wrong calculation of pred_ctr_y #318

Closed csuncs89 closed 6 years ago

csuncs89 commented 6 years ago

This error is severe and obvious

csuncs89 commented 6 years ago

When the images has very different widths and heights, the results would be ridiculous

endernewton commented 6 years ago

Thanks a lot @csuncs89 ! @Detry322 can you verify this?

Detry322 commented 6 years ago

I guess I didn't run into this bug since all of the images I tested on were roughly square. Thanks for finding this!

endernewton commented 6 years ago

@Detry322 When you have time, could you do one more thing (as I see part of the original code is removed):

  1. get back the original code, but leave the tf operation based code (your part) the default option -- you can add an option there to specify it.
  2. submit a pull request. Thanks ahead!
Detry322 commented 6 years ago

Done - #319

endernewton commented 6 years ago

Awesome! Thanks @Detry322 !