search

endersoncosta / herbs2knex

Other
0 stars 2 forks source link

Implemented withSchema to remove string concatenation #13

Open m7vicente opened 3 years ago

m7vicente commented 3 years ago

As described in issue #6 we implemented withSchema on construction of repository to remove string concatenation on tableQualifiedName who no more exist in class.

endersoncosta commented 3 years ago

No test will be implemented or changed to this new scenery? If we don't pass the schema, the code will work?

The knex work with various types of DBMS, then we need to maintain the support, no?

For example, SQLite is a database without schema, this code will work?

BritoDoug commented 3 years ago

About the @endersoncosta commentaries 1 - All the unit tests who use the runner method has been changes, the DB tests dont have changes 2 - withSchema works fine with null and undefined values, we maked some test with it 3 - We runned DBMS tests, we really don't make the specific tests to SQLite, but use PG and SQLServer. How I said, without the schema values, the Knex find a way.

dalssoft commented 3 years ago

@endersoncosta good point. I think it should have a couple of tests specific to this method