search

endeve / thornado

BSD 3-Clause "New" or "Revised" License
17 stars 10 forks source link

Updated Two Moment positivity limiter for adding geometric correction… #18

Closed ranchu1 closed 3 years ago

ranchu1 commented 3 years ago

Updated Two Moment positivity limiter for adding geometric correction: enabled curvilinear coordinate.

jaharris87 commented 3 years ago

Looks good.

Thought I could find a way to do the ComputeCellAverage with linear algebra libraries, but it doesn't quite work out.

ranchu1 commented 3 years ago

Looks good.

Thought I could find a way to do the ComputeCellAverage with linear algebra libraries, but it doesn't quite work out.

We can hold the merge if you want. I don't think anyone needs the new limiter badly. Or, since it's functioning correctly, we can take it as a new baseline to work on.

jaharris87 commented 3 years ago

We can proceed with the merge as a new baseline.