Closed jaharris87 closed 1 year ago
Also, I'd accept feedback from @dunhamsj , @eendeve , or others that see this if there might be a better way to do this.
Particularly, I made a choice to pass in MeshX
, but maybe just passing element centers and widths would be better?
This PR contains 2 things:
ComputeGeometryX
to allow computation on a local mesh and geometry, independent of the globalMeshX
andCoordinateSystem
from modules.ComputeGeometryX
so that it can be called withoutG
already being on the GPU, as would have been the case with the existingupdate
directives. A side effect of this is thatG
will not be up-to-date on the host unless copied over elsewhere---I think this is okay since I don't believe we useG
anywhere on the host except in diagnostics or I/O, where it is already being explicitly updated.@dunhamsj I think this PR likely effects you the most, so could you review my changes an maybe test this to make sure you're still getting the same/correct answers?