endgameinc / dga_predict

GNU General Public License v2.0
271 stars 131 forks source link

BUG: Current code generates twice more benign labels than needed #4

Open asafnadler opened 6 years ago

asafnadler commented 6 years ago

The function gen_data takes the count of malicious+benign domains and adds this number of labels to the malicious labels.

rastafrange commented 6 years ago

@asafnadler I've just checked and it seems to work okay for me. I have labels correctly assigned. Do you have not correct labels for malicious domain?

KuangHao95 commented 5 years ago

In data.py: domains += get_alexa(len(domains)) labels += ['benign']*len(domains) change to: pre_len = len(domains) domains += get_alexa(len(domains)) labels += ['benign']*pre_len

Use previous domain list length to generate labels with same length, or just divide latter length by 2.