endgameinc / eqllib

MIT License
158 stars 46 forks source link

Fix broken normalization #34

Closed rw-access closed 4 years ago

rw-access commented 4 years ago

Issues

32

Details

Some changes in #33 broke other normalization by overriding set_context. Apparently, I only ran the unit tests for those changes, not existing unit tests. This restores that. There's no CI on this repository yet, but here's the output:

======================================================================= test session starts ========================================================================
platform darwin -- Python 3.7.3, pytest-3.8.2, py-1.8.0, pluggy-0.9.0 -- 
cachedir: .pytest_cache
plugins: cov-2.7.1
collected 14 items                                                                                                                                                 

tests/test_analytics.py::TestAnalytics::test_schema PASSED                                                                                                   [  7%]
tests/test_normalization.py::TestNormalization::test_eql_analytics PASSED                                                                                    [ 14%]
tests/test_normalization.py::TestNormalization::test_invalid_normalization PASSED                                                                            [ 21%]
tests/test_normalization.py::TestNormalization::test_normalize_in PASSED                                                                                     [ 28%]
tests/test_normalization.py::TestNormalization::test_normalize_kv PASSED                                                                                     [ 35%]
tests/test_normalization.py::TestNormalization::test_normalize_missing_field PASSED                                                                          [ 42%]
tests/test_normalization.py::TestNormalization::test_normalize_sequence_with_pipe_fields_endgame PASSED                                                      [ 50%]
tests/test_normalization.py::TestNormalization::test_normalize_sequence_with_pipe_fields_sysmon PASSED                                                       [ 57%]
tests/test_normalization.py::TestNormalization::test_normalize_wildcard_basename PASSED                                                                      [ 64%]
tests/test_normalization.py::TestNormalization::test_normalize_wildcard_dirname PASSED                                                                       [ 71%]
tests/test_normalization.py::TestNormalization::test_normalize_wildcard_dirname_argument PASSED                                                              [ 78%]
tests/test_normalization.py::TestNormalization::test_normalize_wildcards PASSED                                                                              [ 85%]
tests/test_normalization.py::TestNormalization::test_unmodified_endgame PASSED                                                                               [ 92%]
tests/test_normalization.py::TestNormalization::test_unmodified_unique_count PASSED                                                                          [100%]

-------------------------------------------------- generated xml file: eqllib/junit.xml ---------------------------------------------------