search

endigma / unocss-preset-radix

A preset for UnoCSS to let you use Radix color palette
https://endigma.github.io/unocss-preset-radix/
MIT License
32 stars 6 forks source link

Light/Dark Alpha and overlay colors are not included #4

Closed thewebartisan7 closed 1 year ago

thewebartisan7 commented 1 year ago

I see that you are excluding alpha and overlay (whiteA/blackA) colors and some code are commented.

Is there a reasons why you didn't include them?

Can we add back? I can make PR.

endigma commented 1 year ago

Honestly I don't know what to use them for, and I planned to add proper unocss opacity support at some point. I'd accept a PR adding the alpha variants.

thewebartisan7 commented 1 year ago

Thanks for quick reply. I will check into alpha variants in next days and open PR.

Honestly I don't know what to use them for, and I planned to add proper unocss opacity support at some point.

I am not sure what are the benefits of using unocss opacity support instead of already created radix one? I am new to unocss so I am maybe missing the point.

Yes it's not common, but there is use case, for example could be an overlay background on some images so you can add some text or button on top of it.

I think it's better have it ready to be used since Radix provide it, rather than not having it when you need.

Can I also add the whiteA and blackA, as this are nice to be used with overlays such as modal, and they don't change with dark theme.

thewebartisan7 commented 1 year ago

@endigma I open PR for this https://github.com/endigma/unocss-preset-radix/pull/5

Let me know your feedback.