endless-sky / endless-sky-editor

Map editor for the Endless Sky universe.
GNU General Public License v3.0
68 stars 44 forks source link

Same star system rename problem #11

Closed chinotauku closed 5 years ago

chinotauku commented 7 years ago

When I rename on the same system, It's will pop-up a "the name has existed system" worming window sometimes.

tehhowch commented 6 years ago

Seems to be a general issue associated with name or government changes when you use the keyboard to confirm changes and then advance fields. If you use the mouse, there generally aren't these issues.

If I use Enter to "confirm" the name change, then Tab to switch to the government - that is generally when the "Duplicate name" error appears (and a very high chance of segfaulting in DetailView::NameChanged() or DetailView::GovernmentChanged(), due to inaccessible system properties.

tehhowch commented 6 years ago

I believe this is fixed with #17