search

endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.58k stars 1k forks source link

Rehire extra crew checkbox in crew panel #10182

Open Zarkonnen opened 1 month ago

Zarkonnen commented 1 month ago

Problem Description

The most common mistake I make when playing ES is that I forget to re-up my extra hired crew before leaving a planet. While writing this issue I discovered that there is a setting to rehire extra crew, in the 2nd settings page. So the functionality is there but it's very non-discoverable.

Related Issue Links

I looked through existing issues and discussions and found https://steamcommunity.com/app/404410/discussions/0/3199245116710388532/ which I based this on.

Desired Solution

Can you add a checkbox for the rehire extra crew setting (or a player-local version of the setting) in the crew panel, to co-locate the setting with the functionality it addresses?

Alternative Approaches

n/a

Additional Context

No response

TheGiraffe3 commented 1 month ago

This would be really good to have. Unfortunately, I don’t think the PlanetPanel supports check boxes. But if it could be a toggleable button like the one in the settings, that might work. It could go to the left of the Hire button.

TomGoodIdea commented 1 month ago

The most common mistake I make when playing ES is that I forget to re-up my extra hired crew before leaving a planet. While writing this issue I discovered that there is a setting to rehire extra crew, in the 2nd settings page. So the functionality is there but it's very non-discoverable.

skill issue but seriously I think there were a few complaints about settings discoverability before, so maybe it should be done in a more general way than just linking one setting to the hiring panel

Zarkonnen commented 1 month ago

What would a more general way look like?

TomGoodIdea commented 1 month ago

We have the first-time help popups and could use this system to tell people to check out the preferences, but this method of providing help is disputable itself, so idk.

SomeTroglodyte commented 1 month ago

It doesn't work properly anyway - OK, it works as designed, but doesn't meet human expectations. That's because every time you land on something without the crew service, your desired crew strength gets reset to what you have at that point - PlayerInfo.cpp line 1873.

Zarkonnen commented 1 month ago

We have the first-time help popups and could use this system to tell people to check out the preferences, but this method of providing help is disputable itself, so idk.

In my own experience, the first time help popups don't work well, because you don't remember their contents.