search

endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.92k stars 1.04k forks source link

Make the Ship Info cargo column scrollable, or add as a separate tab with columns #10598

Open opusforlife2 opened 1 month ago

opusforlife2 commented 1 month ago

Is there an existing issue for this?

Describe the bug

If there are too many kinds of cargo items on a ship, scanning it causes the popup to go out of bounds of the display. For me, the maximum number of viewable items is 31. I assume that with larger or smaller display/resolution combos, this threshold could be different.

I encountered this for an outfit scan too quite a while ago. The memory is vague, but it might have been the Heron, not sure. It's somewhat easier to encounter this because of the headers separating the different categories.

While testing, I realised that the Ship Info cargo list just straight-up omits items if they can't fit in the given space.

Steps to Reproduce

Scan ship with really large cargo/outfit list, or, more reliably:

  1. Have a really-tiny-cargo-space flagship, and a massive cargo escort.
  2. Put 1 of as many different kinds of cargo as you can in it.
  3. Scan it.

Also, open Ship Info screen and view the cargo column. Note the missing items.

Expected Behavior

The popup list should be scrollable. Or, the list should occupy 2 or more columns if it overruns a set percentage of display height.

I don't think there's anything else that can be done for the Ship Info cargo list except making it scrollable. Or, maybe, the entire cargo list could be shifted into a 3rd tab, separate from Player Info and Ship Info. This would allow multiple columns here too.

Screenshots

I tried taking a screenshot of the popup, but apparently the game has a 'security feature' where the screenshot always turns out to be of the pause menu. ಠ_ರೃ see https://github.com/endless-sky/endless-sky/issues/10598#issuecomment-2416040679

Link to save file

No response

Operating System

W10

Game Source

GitHub Releases

Game Version

0.10.8

Additional Information

No response

warp-core commented 1 month ago

Dialogs are scrollable in 0.10.9, including the scan dialogs.

opusforlife2 commented 1 month ago

New scroll bar for various UI elements.

Damn it. xD

Edit: What about the Ship Info cargo list?

warp-core commented 1 month ago

Edit: What about the Ship Info cargo list?

You're right, that doesn't have scrolling yet.

opusforlife2 commented 1 month ago

the screenshot always turns out to be of the pause menu

Any idea what's up with this? Should I open a new issue for this?

tibetiroka commented 1 month ago

It's not intentional, and I never had this happen. We don't even show the pause screen if you tab out, so I'm not sure what can cause this. It should only show up when you press Escape (and you can't do that on the player info panel directly, I think?)

opusforlife2 commented 1 month ago

So what I was doing was: PrntScr on the scan popup for the screenshot, then pause, Alt+Tab to another software like Paint or an image viewer, and paste.

Kept pasting the Pause screen every time. Do these steps work correctly for you?

tibetiroka commented 1 month ago

I'm on linux, but it works correctly here.

opusforlife2 commented 1 month ago

Thanks. I'll see if I'm able to debug this.

TheGiraffe3 commented 1 month ago

Works alright on a Mac.

TomGoodIdea commented 1 month ago

related: #7868

So what I was doing was: PrntScr on the scan popup for the screenshot, then pause, Alt+Tab to another software like Paint or an image viewer, and paste.

Kept pasting the Pause screen every time. Do these steps work correctly for you?

When you alt-tab back to the game, does it show the menu, or is it only on the screenshot?

opusforlife2 commented 1 month ago

If I leave the game at the Pause menu, it's at the menu. If I leave it at some other screen, and switch back, it stays on that screen as expected.

However, the screenshot is still of the Pause menu somehow, despite never switching to it. Basically, the Pause menu is screenshot-bombing me.

Edit: Figured it out with some reading over at the MS answers forum. As it turns out, when Windows switches to the game in full screen, that exact moment is what gets captured in the screenshot that follows, even if it is taken a long time later. So what you have to do is: ensure that the exact thing you want to screenshot is on display in front of you, switch away from and back to the game once, and then take a screenshot.

TomGoodIdea commented 1 month ago

sounds like something windows could do