endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.79k stars 1.03k forks source link

Cargo space shown unified, but treated as per-ship #10599

Open opusforlife2 opened 1 day ago

opusforlife2 commented 1 day ago

Is there an existing issue for this?

Describe the bug

The game requires cargo items to completely fit inside a ship. However, the player is able to put items in cargo even if individual ships don't have space, due to the pooled cargo space shown.

The player isn't stopped from adding more cargo. Instead, a warning is shown upon trying to depart. Then, the player must play a small trial-and-error guessing game of which item(s) to remove from cargo in order to fit the requirement.

Steps to Reproduce

  1. Have a couple ships at least.
  2. Put very large items in the cargo, such that the last cargo item can't fit onto any one ship.
  3. Try to depart.

Expected Behavior

The game should stop the player from putting stuff in cargo if it cannot be carried in a single ship.

To help with this, the Outfitter screen shouldn't just show a single "cargo space" number, but a complete breakdown of each ship's cargo space. As individual ships get filled, they should become greyed out. Sure, the numbers might jump around as the game readjusts outfits from one ship to another as more get added, but at least the player will get some idea of what's going on.

The list would need to be scrollable to account for a large fleet.

Screenshots

No response

Link to save file

No response

Operating System

W10

Game Source

GitHub Releases

Game Version

0.10.8

Additional Information

No response

esksp commented 1 day ago

Even worse: Apparently if you park a ship, its cargo allowance remains active. Meaning you can park a couple hefty cargoes somewhere, forget them, and still use their virtual cargo space on a small, fast and nimble craft...

(Unconfirmed, since I've noticed this with custom ships, and given I was tweaking and fine-tuning all the time I can't be sure which part of this is my own fault, and which is a game oversimplification.)