endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.83k stars 1.03k forks source link

Peregrine intro outdated due to Puffin/Penguin/Merganser intros #10617

Open opusforlife2 opened 1 week ago

opusforlife2 commented 1 week ago

Is there an existing issue for this?

Describe the bug

It seems obvious that these ships were added to the game well after the Peregrine, and the conversation accompanying its introduction wasn't updated accordingly.

Why? Because after all that time Taely spends waxing poetic about how the Merganser (and the Penguin, if you chose that path) are "alive", she goes on to give the whole spiel yet again while introducing the Peregrine.

A similar whole paragraph is spent talking about the gaslining attribute, when you can only reach this point after you've landed on a gas giant at least a few times.

Steps to Reproduce

Read the Puffin, Penguin, Merganser and Peregrine intro conversations.

Expected Behavior

All 4 conversations should make sense semantically as per their chronology, with a branched path for Penguin (already done for the Merganser intro).

Puffin is the first gasliner. Penguin is the first 'truly alive' ship and a prototype. Merganser is also the first 'truly alive' ship (check their shipyard descriptions!) and not a prototype. (Strange that a prototype and its final iteration are both infinitely available for purchase.)

So, the only thing left to talk about regarding the Peregrine is that it's a cloaking-capable medium warship.

Screenshots

No response

Link to save file

No response

Operating System

W10

Game Source

GitHub Releases

Game Version

0.10.8

Additional Information

No response

warp-core commented 1 week ago

It would be useful to quote the text you are referring to, rather than making everyone who wants to understand this issue go find it for themselves, which may involve considerable guesswork if they are not already familiar with it.

Perhaps ironically, the conversation about the Peregrine was actually added in the same PR as the conversation about the Merganser (though I don't know what the interval for writing the two was) both of which came after the Penguin.

opusforlife2 commented 1 week ago

That makes this incongruity even stranger, then. Perhaps the order of introduction of the ships was still in flux, and this was a 'remnant' of a prior decision. Brb with the text.

opusforlife2 commented 1 week ago

Puffin gaslining: https://github.com/endless-sky/endless-sky/blob/742fed8aa2829069e44ecca614ec7a3f1b8d3d38/data/remnant/remnant%201%20introduction.txt#L686

Penguin "It's aliiiiiiiiive!" : https://github.com/endless-sky/endless-sky/blob/742fed8aa2829069e44ecca614ec7a3f1b8d3d38/data/remnant/remnant%201%20introduction.txt#L2932

Merganser puppies: https://github.com/endless-sky/endless-sky/blob/742fed8aa2829069e44ecca614ec7a3f1b8d3d38/data/remnant/remnant%202%20cognizance.txt#L1005

Merganser "1st truly alive" : https://github.com/endless-sky/endless-sky/blob/742fed8aa2829069e44ecca614ec7a3f1b8d3d38/data/remnant/remnant%20ships.txt#L969

But Penguin "truly alive" : https://github.com/endless-sky/endless-sky/blob/742fed8aa2829069e44ecca614ec7a3f1b8d3d38/data/remnant/remnant%20ships.txt#L1184

And finally, the overripe Peregrine explanation: https://github.com/endless-sky/endless-sky/blob/742fed8aa2829069e44ecca614ec7a3f1b8d3d38/data/remnant/remnant%202%20cognizance.txt#L1413