search

endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.83k stars 1.03k forks source link

Deprecation on in stock outfits don't carry over if you reload the save #1738

Closed Amazinite closed 7 years ago

Amazinite commented 8 years ago

Title says it all.

If you sell an outfit that is deprecated then reload the save, that outfit will remain in stock but lose its deprecation and require the full cost to purchase.

endless-sky commented 8 years ago

Are you sure? It's working properly for me - i.e. if I sell a depreciated outfit, then quit and restart the game, it shows up with that outfit in stock and its "cost" being the depreciated value.

endless-sky commented 8 years ago

Could this actually just be #1741?

Amazinite commented 8 years ago

I don't believe so.

Here is an atomic engine that I've been using for a while now. It currently has full deprecation on it, and I just sold it into stock, screenshot_1

I then reloaded the save, and the deprecation was removed. screenshot_2

This is only happening on outfits not normally sold at that outfitter; selling a deprecated outfit that is normally sold at that outfitter then reloading the save will still have that outfit being properly deprecated.

ReimeiSky commented 7 years ago

my experience: Had a fully depreciated (25%) NT-200 nucleovoltaic generator installed. Plundered a fission reactor from a pirate clipper. Landed and replaced the nucleovoltaic with the (25% depreciated) fission reactor. Took off, reloaded save. Nucleovoltaic was no longer depreciated. Somehow, it is now worth more than the bloody fission reactor.

endless-sky commented 7 years ago

It turns out this was only happening with fully depreciated items, which took me a while to track down. Commit cfdce03 fixes this.

Amazinite commented 7 years ago

Awesome.