endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.89k stars 1.04k forks source link

Some weapons reuse sounds #2072

Open ReimeiSky opened 7 years ago

ReimeiSky commented 7 years ago

Bombardment cannons use the blaster sound, finishers use the torpedo sound, ion rain guns use the particle cannon sound, and attractors and repulsors respectively use the laser and heavy laser sounds.

Intentional?

Lorantine commented 7 years ago

temporarily (seems logical to me)

endless-sky commented 7 years ago

I wanted to get the Heliarch weapons in 0.9.5 so that the balance could be tested, but didn't have time before the release to create the outfit sprites, sounds, etc.

Amazinite commented 7 years ago

Stares at 0.9.x tag that should be changed to v0.9.6 (done)

ReimeiSky commented 7 years ago

shrug

ReimeiSky commented 7 years ago

Reopening for the Remnant weapons. Inhibitor cannon and thrasher cannon + turret all reuse the particle cannon sound, and the point defense turret doesn't even have a sound.

I'd ignore this per your comment in this thread, but 0.9.8 is a stable build...

2017-11-25: moonbeam.

Lorantine commented 7 years ago

don't really see why you'd reopen it sounds are one of the last things weapons get, the current ones are placeholders

tehhowch commented 7 years ago

Remnant sounds were probably taking a bit of time, and rather than delay 0.9.8 by 2-3 weeks just for sounds, sounds got pushed to 0.9.9. I'm curious if there will be a sound theme for the remnant, or if their theme will just be bastardized sounds from the "parent" weapons.

Amazinite commented 3 years ago

Can anyone make a list of all weapon sounds which are reused?

MCOfficer commented 3 years ago

Sure, here's all the sounds that are used more than once:

$ rg 'sound ".*"' data/ -oIN | uniq -d
sound "crunch"
sound "disruptor"
sound "inhibitor"
sound "inhibitor"
sound "thrasher"
sound "sunbeam"
sound "zapper"
sound "repeater"
sound "slicer"
sound "bombardment"
sound "ion rain"
sound "blaster"
sound "mod blaster"
sound "laser"
sound "heavy laser"
sound "electron beam"
sound "proton"
sound "plasma"
sound "pulse"
sound "ion impact"

To correct any logical mistakes on my part, this command:

Amazinite commented 3 years ago

Some of those are reused because gun vs turret.

Amazinite commented 3 years ago

Looked for the exact weapons that use each sound from MCO's list, sifting out any sounds which are only used by a gun and it's respective turret.

sound "crunch": Mouthparts? and Crystalline Formation (Becca person ship weapon)
sound "disruptor": Disruptor and Ravager Beam
sound "inhibitor": Inhibitor Cannon and Annihilator
sound "sunbeam": Sunbeam and Moonbeam
sound "proton": Proton Gun and Sheragi AMT
sound "plasma": Plasma Cannon and Plasma Repeater (Should they be different?)
sound "ion impact": Ion Cannon hit effect and Railgun firing sound
warp-core commented 1 year ago

Moonbeam now has a unique sound so sunbeam can be crossed off that list.