endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.55k stars 998 forks source link

Event hails? #3293

Open ph2000bis opened 6 years ago

ph2000bis commented 6 years ago

Is it conceivable to add hails to the list through an event, either permanently or temporarily? For example, I was thinking of things like:

I believe it could definitively add to the hail diversity and immersion into the game

Lorantine commented 6 years ago

I'm not sure about point 1 (although it seems fine) about point 2, personally I'd make merchants talk about WHAT the player did, while the merchants don't know it was the player (maybe also add some hails where the merchant does know?) point 3 sounds great point 4 might not be worth it for 1 in-game day, and it'd require too much messing around w/ events

in short, I'm for 1, 2 & 3, not for 4 just because implementing it seems unworthwhile

tehhowch commented 6 years ago

Addition could be done, but removal would be difficult - how would one specify which "friendly civilian" phrase to remove? It's possible we could support an index (e.g. remove phrase "friendly civilian" 1 to remove the first phrase set (defaulting to the last added one)) but that would be the limit of specificity. There'd be no way to guarantee removal of a certain mod's set of hails since any number of mods could be loaded together, so what might be phrase 1 in mod A could be phrase 33 if mods B and X are loaded

Amazinite commented 3 years ago

I feel like spaceport news is the much more appropriate place for NPC dialog that comes and goes with events that occur through the story, not only because it's easier to read the spaceport news but also because you're able to add to and remove from what appears. As mentioned, hails have the issue of not being able to remove what you've added, so hails are more appropriate for either not changing with events or only adding to them with timeless hails, e.g. "Remember that time when X happened?" after X occurred.