search

endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.83k stars 1.03k forks source link

Mass in the latest commit is absolutely broken #3480

Closed ReimeiSky closed 5 years ago

ReimeiSky commented 6 years ago

In the latest commit, owned ships' masses are initially treated normally. But once you reload your save, the ships' base masses no longer count toward the total mass. That is, only their outfits count toward the mass. This means that a Punisher, for example, moves twice as fast after reloading.

On that note, hit force is also very weird right now. A heavy rocket and even a meteor missile have far more knockback than a particle cannon, while something like a finisher barely pushes ships around at all.

Also, as @comnom noted, outfit masses aren't even displayed in the outfitter...

Hacklin commented 6 years ago

Confirmed.

The ship's 'mass' attribute is not being saved. Therefore, when you reload, a ship's hull mass is zero.

Note: If you remove all outfits from a ship with a hull mass of zero, the ship's 'acceleration' and 'turning' values in the outfitter are '0 / -nan' ;-)

endless-sky commented 6 years ago

Fixed by merging #3481.