endless-sky / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
5.55k stars 998 forks source link

Drug smuggling mission... to Coalition space #6473

Closed a-random-lemurian closed 2 years ago

a-random-lemurian commented 2 years ago

Is there an existing issue for this?

Describe the bug

I've been getting drug smuggling missions whose destinations are in Coalition space. The mission in question is "Drug Running 3".

mission "Drug Running 3"
    name "Drug Running"
    description "Bring a shipment of illegal drugs to <destination>. If you are caught with this cargo, you may be fined."
    minor
    repeat
    source
        attributes "near earth" "dirt belt" "north"
    destination
        attributes "urban"
        distance 1 100
    cargo "illegal drugs" 5 2 .1
    illegal 70000 `In addition to the fine, the illegal drugs are confiscated from your cargo hold.`
    stealth
    to offer
        random < 10
        has "Drug Running 2: done"

    on offer
        dialog `A well-dressed woman approaches you as you are walking through the spaceport and asks quietly if you would be willing to help facilitate the transport of some "naughty substances" to a certain individual on <planet>.`

    on visit
        dialog phrase "generic cargo on visit"
    on complete
        payment
        payment 120000
        "drug smuggler" ++
        dialog `You hand off the illegal "substances" to your contact on <planet>, who pays you <payment>.`

My plugin, LEESt, links Coalition space to Human space by hyperlane. We might want to reduce the "distance" attribute or only allow the destination to be in human space.

Steps to Reproduce

Do a few drug running missions. You might need to link human space directly to Coalition space.

Expected Behavior

I get the same mission, but the destination should be in human space.

Screenshots

No response

Link to save file

No response

Operating System

Ubuntu 20.04.3

Game Source

Built from source

Game Version

continuous

Additional Information

No response

tehhowch commented 2 years ago

Content written for vanilla is not expected to handle changes to the universe caused by plugins, given that plugins can arbitrarily change the entire game universe.

a-random-lemurian commented 2 years ago

We should reduce the distance attribute or restrict this mission to only Republic, Syndicate, Free Worlds, Pirate, Neutral, and Independent space.

tehhowch commented 2 years ago

Note that distance 1 100 is used from within a region of space not linked to alien regions to mean "anywhere in human space". Another way used to indicate this intent is near "Sol" 100. Distances were used to avoid needing to account for all the possible current and future governments in play.

a-random-lemurian commented 2 years ago

Note that distance 1 100 is used from within a region of space not linked to alien regions to mean "anywhere in human space". Another way used to indicate this intent is near "Sol" 100. Distances were used to avoid needing to account for all the possible current and future governments in play.

Alright, so what should I do with this issue?

Close it or something?

W1zrad commented 2 years ago

Close it or something?

Sounds like this concern is resolved, so yup!