search

endlessm / azafea

Service to track device activations and usage metrics
Mozilla Public License 2.0
10 stars 2 forks source link

Use the same Dockerfile as we use in production. #106

Closed adarnimrod closed 4 years ago

adarnimrod commented 4 years ago

In production in Endless, we use a different Dockerfile with a slightly different setup. The main points are using the Alpine variant of the Python base image and rendering a config.toml file from a template and environment variable. This commit uses (almost) exactly the same Dockerfile that we use in production since Azafea was deployed and it can be argued that it's the most tested one. We don't have a dev/ prod image so that build argument is dropped.

adarnimrod commented 4 years ago

BTW, this will fix the breaking CI and #103.

wjt commented 4 years ago

I do not have enough context to meaningfully review this

mcatanzaro commented 4 years ago

I was able to avoid all problems by switching from podman to docker, and from Ubuntu Disco to Ubuntu Eoan.

Updating the Dockerfile for azafea-metrics-proxy would be good to do as well.

mcatanzaro commented 4 years ago

Updating the Dockerfile for azafea-metrics-proxy would be good to do as well.

endlessm/azafea-metrics-proxy/issues/12