Strip useless quotes and field from OS information

endlessm / azafea

Service to track device activations and usage metrics

Mozilla Public License 2.0

10 stars 2 forks source link

Strip useless quotes and field from OS information #111

Closed liZe closed 4 years ago

liZe commented 4 years ago

OS information fields get useless extra quotes and field in the payload.

This pull request:

~~drops the useless name column,~~
strips the useless quotes around version (and name) before inserting new rows,
adds a command removing useless quotes from version (and name) in database.

~~This is a draft because:~~

~~it needs endlessm/eos-metrics-instrumentation#88 (draft too),~~
~~it includes an Alembic migration and thus has to be adjusted when #109 is merged.~~

https://phabricator.endlessm.com/T29322

wjt commented 4 years ago

it needs endlessm/eos-metrics-instrumentation#88 (draft too),

I don't think it does. This code needs to cope with both the old and new submission formats, since there will be machines in the wild running old versions of the client code forever. As far as I can see, it does deal.

liZe commented 4 years ago

it needs endlessm/eos-metrics-instrumentation#88 (draft too),

I don't think it does.

I wanted to say that we need to merge #88 sooner or later. We won’t forget now that it’s merged :smile:…

I would ask to split the migration that drops the column to a separate PR that will deploy later. Everything else looks good to me.

I’ve put the migration into the lize/drop-os-name branch (including the commits from this PR). I’ve changed this PR to remove useless quotes from name too, even if the column is removed later.

adarnimrod commented 4 years ago

Deployed to the test and dev environments. Worked without an issue and the migrations worked correctly. Merging.