Store 2-letter country codes in database

endlessm / azafea

Service to track device activations and usage metrics

Mozilla Public License 2.0

10 stars 2 forks source link

Store 2-letter country codes in database #113

Closed liZe closed 4 years ago

liZe commented 4 years ago

This PR includes these changes:

DB migration allowing both alpha2 and alpha3 codes in PostgreSQL,
SQLAlchemy changes allowing ~~only alpha2~~ alpha2 and alpha3 codes when inserting new records,
CLI commands added for country code migration in ping_v1 and activation_v1.

https://phabricator.endlessm.com/T29210

liZe commented 4 years ago

This PR has been updated to allow both alpha2 and alpha3 codes for new rows. We can keep this version on production, update eos-activation-server to send alpha2 codes, and then merge the lize-country-alpha-2-only branch.

liZe commented 4 years ago

~~:warning: We should wait for #112 to be merged before changing the Alembic deployment version and merging this PR. :warning:~~

liZe commented 4 years ago

We should wait for #112 to be merged before changing the Alembic deployment version and merging this PR.

This PR includes migrations for ping and activation, and #112 includes a migration for metrics. It means that we don’t need to rebase these deployments, and that we can deploy #112 and #113 in any order.