search

endlessm / azafea

Service to track device activations and usage metrics
Mozilla Public License 2.0
10 stars 2 forks source link

Add documentation for new wire format #149

Closed liZe closed 3 years ago

liZe commented 3 years ago

https://phabricator.endlessm.com/T31728

liZe commented 3 years ago

I’ve rebased new-protocol-doc on top of master and metrics-v3, because the documentation needs the code to be complete. There’s actually no reason to not merge new-protocol-doc into metrics-v3, before merging metrics-v3 into master.

I’ll mark this PR as ready for review when metrics-v3 is rebased on top of master.

liZe commented 3 years ago

I think that it’s ready to be merged. The only change with v3/T32144 is the unsigned 32-bit for aggregate counts, I can add a comment on T32144 when merged. Let me know if this latest change is useless, I can revert it.

I’ve kept the original commits and squashed the various document changes at the end (giving a quite dirty commit). I can rebase more if needed.

wjt commented 3 years ago

That seems fine to me. 4 billion seconds (49,710 days) or logged-in users ought to be enough for anyone.