Open antoinehashbang opened 3 years ago
@wjt As discussed earlier, this branch is not ready to be merged, but I’d appreciate a "quick" review to check that everything is OK so far.
What’s missing and/or wrong:
union_all
in queries requires columns, not tables,channel_id
needs to replace channel columns, with a solution to get both V2 and V3 channels.I wish I had some extra time to finally merge this PR…
I’ve marked as "resolved" the comments of @wjt’s review that are now resolved. Here’s what’s missing:
channel_id
instead of the channel attributes;View.__getattr__
to wrap more table attributes;Don’t hesitate to ping me in this PR if you need anything!
https://phabricator.endlessm.com/T32156