search

endlessm / azafea

Service to track device activations and usage metrics
Mozilla Public License 2.0
10 stars 2 forks source link

Add request model for metrics v3 #160

Closed antoinehashbang closed 2 years ago

antoinehashbang commented 2 years ago

https://phabricator.endlessm.com/T32318

wjt commented 2 years ago

This PR is fine!

On Wed, 21 Jul 2021 at 16:32, antoinehashbang @.***> wrote:

@.**** commented on this pull request.

In azafea/event_processors/endless/metrics/v3/migrations/b0f69709d3f6_add_request_model_metrics_v3.py https://github.com/endlessm/azafea/pull/160#discussion_r674086126:

  • op.drop_column("invalid_aggregate_event_v3", "receveid_period_start")
  • op.drop_column("unknown_aggregate_event_v3", "receveid_period_start")

Yes, I saw this today, it was a column I had added and then removed in this table and I must have forgotten to re-generate the migrations after I removed them.

I'm going to put this in a separate commit, would you prefer I leave it in this PR or open another one for it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/endlessm/azafea/pull/160#discussion_r674086126, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVF2ALNQATCGHFLP7VP6TTY3SA7ANCNFSM5AV3F5GQ .