Aggregate event tweaks - Githubissues

endlessm / azafea

Service to track device activations and usage metrics

Mozilla Public License 2.0

10 stars 2 forks source link

Aggregate event tweaks #165

Closed dbnicholson closed 2 years ago

dbnicholson commented 2 years ago

Adjust the v3 aggregate event handling to match recent changes on the client side. The only significant changes are in the last 2 commits:

Use uuid5 to generate monthly aggregate event IDs from their daily aggregate event counterparts.
Allow sending a period start string of %Y-%m for aggregate events as will be used for monthly aggregate events.

The rest was me haggling with the test suite to be able to run it locally and have it pass.

https://phabricator.endlessm.com/T32670

dbnicholson commented 2 years ago

I haven't actually run the integration tests locally, so marking as a draft until I see what happens with them.

dbnicholson commented 2 years ago

Perhaps my lack of knowledge on azafea can make me miss important details here, but so far every commit looks great. The commit messages were very didactic slightly_smiling_face

I'm not militant about many things, but git commit messages is one of them!