search

endlessm / electron-installer-flatpak

Create a flatpak for your Electron app
MIT License
59 stars 17 forks source link

flatpak-bundler ensureSdk() broken #26

Closed mikelpr closed 5 years ago

mikelpr commented 5 years ago

What version of electron-installer-flatpak are you using? 0.8.0

ensureSdk() of flatpak-bundler is broken, as there's no sdk-version field to be used (it's runtime-version, as the sdk is the devel package for that runtime) so instead of return ensrueRef(options, manifest['sdk-flatpakref'], manifest['sdk'], manifest['sdk-version']) it should be return ensrueRef(options, manifest['sdk-flatpakref'], manifest['sdk'], manifest['runtime-version'])

as flatpak-bundler hasn't been updated since 2017, I thought it would be better to report here

ptomato commented 5 years ago

Thanks for the report, it makes sense! Would you like to make a pull request to flatpak-bundler and tag me for review?

mikelpr commented 5 years ago

heh, you already had fixed it

the problem actually is that you didn't publish 0.1.4 to npm. I filed a bug over at endlessm/flatpak-bundler

ptomato commented 5 years ago

Oh, okay, thanks :smile: