endlessm / endless-key-app

Endless Key app for Windows (formerly known as kolibri-app)
https://www.endlessos.org/key
MIT License
2 stars 1 forks source link

Windows Security Alert on first run of Endless Key #135

Open wjt opened 1 year ago

wjt commented 1 year ago

After the app is installed (and I believe also after it is reinstalled, and perhaps also after clearing the app data), when it is first launched, and after selecting a content pack, the following security alert is shown:

image (10)

Windows Defender Firewall has blocked some features of this app

I believe without proof that this is secret code for "The Kolibri server is trying to listen over the network, not just on localhost, and Windows doesn't let it do this by default".

We have fixed this once before, in https://github.com/endlessm/endless-key-app/pull/20. It was then un-fixed in passing in https://github.com/endlessm/endless-key-app/commit/83414d5f99195b943ef109cd6b0fec6b0274f053.

Dependencies:

starnight commented 1 year ago

I think fixing the IP as 127.0.0.1 with the environment variable KOLIBRI_LISTEN_ADDRESS is good enough:

INFO 2023-08-17 20:16:52,312 kolibri.utils.server Bus state: START
INFO 2023-08-17 20:16:52,351 kolibri.core.tasks.main Starting async task workers.
INFO 2023-08-17 20:16:52,356 kolibri.core.tasks.worker Requeuing stalled jobs.
INFO 2023-08-17 20:16:52,359 kolibri.utils.server Started monitor thread 'ProcessControlPlugin'.
INFO 2023-08-17 20:16:52,466 kolibri.utils.server Starting on 127.0.0.1:5000
INFO 2023-08-17 20:16:52,574 kolibri.utils.server Waiting for 127.0.0.1:5000
INFO 2023-08-17 20:16:52,576 kolibri.utils.server Serving on 127.0.0.1:5000
INFO 2023-08-17 20:16:52,577 kolibri.utils.server Kolibri running on: http://127.0.0.1:5000/
INFO 2023-08-17 20:16:52,686 kolibri.utils.server Starting on 127.0.0.1:5001
INFO 2023-08-17 20:16:52,795 kolibri.utils.server Waiting for 127.0.0.1:5001
INFO 2023-08-17 20:16:52,811 kolibri.utils.server Serving on 127.0.0.1:5001
INFO 2023-08-17 20:16:52,819 kolibri.utils.server Bus state: RUN
vanessa-chang commented 1 year ago

Tested on v 6.38.5.0 I can still see the Security Alert.

IMG_2148

starnight commented 7 months ago

Sorry! I place the comment on wrong ticket.