search

endlessm / endless-key-app

Endless Key app for Windows (formerly known as kolibri-app)
https://www.endlessos.org/key
MIT License
2 stars 1 forks source link

kolibri-electron: Bump electron to v22.3.16 #140

Closed starnight closed 1 year ago

starnight commented 1 year ago

Electron Release stable version includes 22.3.16 with node.js 16. https://releases.electronjs.org/release/v22.3.16

Hope this fix the PDF reader rendering with an NVIDIA card issue.

Fixes: https://github.com/endlessm/endless-key-app/issues/133

starnight commented 1 year ago

The new Electron does not fix https://github.com/endlessm/endless-key-app/issues/133. So, I drop the corresponding text from the commit message.

wjt commented 1 year ago

Can you share the steps you took to bump the Electron version? What tools did you use to do so? Is this documented anywhere?

starnight commented 1 year ago

I simply update package.json manually, then build kolibri-electron once on Windows by following the steps in CI to have new yarn.lock.

wjt commented 1 year ago

@dylanmccall in general is there a "fancier" way to update package.json?

starnight commented 1 year ago

Rebased on master branch again.