endlessm / endless-key-app

Endless Key app for Windows (formerly known as kolibri-app)
https://www.endlessos.org/key
MIT License
2 stars 1 forks source link

Replace Electron with PyWebview for Endless Key App #141

Closed starnight closed 10 months ago

starnight commented 1 year ago

We have:

More benefits:

The original Endless Key app is executed by running kolibri-electron, which is an Electron app.

  1. Show the maximized webview window and browsing kolibri_explore_plugin's welcomeScreen.
  2. Check KOLIBRI_HOME is created, or not.
  3. Run kolibri server at backend. But, frontend has to wait kolibri server up.
  4. If kolibri server is ready, then change frontend to Kolibri's explore. Finally, frontend works with kolibri server.

Here lists some key tech for transferring to PyWebview:

starnight commented 1 year ago

Prototype the happy path without USB feature (2 weeks)

This could be tracked in Prototype moving the front-end of Endless Key app (Windows) from Electron to pywebview

Check KOLIBRI_HOME is created (2 days)

This follows previous prototype. With this feature, no more download action if KOLIBRI_HOME is created.

Add Endless USB key feature (1 week)

Integrate CI (3 days)

This is more related to build and packaging

starnight commented 10 months ago

Thanks to:

The porting becomes simpler.

PR #161 is ready for review now.

erikos commented 10 months ago

Testing results are looking very promising for this one. I was able to use the app fine in Windows 11, using the build artifact.

manuq commented 10 months ago

This is ready to be deployed.

vanessa-chang commented 10 months ago

Verified Passed in Windows 7.8.3.0